Skip to content

Conversation

@rajathagasthya
Copy link
Contributor

@rajathagasthya rajathagasthya commented Jan 14, 2026

Description

Removes static, handcrafted MIG config file and uses config generated dynamically by mig-parted CLI, if a custom config is not specified.

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Tested by deplying MIG manager changes in NVIDIA/mig-parted#295 on nodes with different types of GPUs to verify generated config.

@rajathagasthya rajathagasthya changed the title WIP: Add support for dynamic MIG config generation Add support for dynamic MIG config generation Jan 22, 2026
@rajathagasthya rajathagasthya marked this pull request as ready for review January 22, 2026 18:08
@rajathagasthya rajathagasthya force-pushed the dynamic-mig-config branch 2 times, most recently from 1e56440 to f7b2f8f Compare January 26, 2026 21:14
Copy link
Contributor

@cdesiniotis cdesiniotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's get NVIDIA/mig-parted#295 in first before merging this. Thanks @rajathagasthya!

Copy link
Contributor

@cdesiniotis cdesiniotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take my approval back, as I see the go-checks failed.

Removes static, handcrafted MIG config file and uses config generated
dynamically by mig-parted CLI, if a custom config is not specified.

Signed-off-by: Rajath Agasthya <ragasthya@nvidia.com>
@rajathagasthya
Copy link
Contributor Author

@cdesiniotis I rebased. This will fix the go-checks failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants